One of the big challenges is our ability to accurately assess risk. Sensational videos help skew perceived risk and IMO don’t accurately reflect the actual risks on any given typical flight.
I think they also foster either a “ I will never be that dumb” attitude or “something terrible that I can’t predict or recover from could happen on every flight” fatalism. Both ideations are not particularly helpful.
That being said I think there can be value in videos especially for examples of systems failures. Having already seen the developing symptoms of a particular failure may help pilots recognize it when it happens to them.
Finally I think accident videos should be treated like any other media. Consider the source, the motivation of the author/presenter and treat it as a data point, not the last and only answer.